Rewrite ckeditor5-cloud-services and ckeditor5-ckbox to TypeScript. #13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mremiszewski
suggested changes
Jan 24, 2023
|
|
||
| import CKBoxUI from './ckboxui'; | ||
| import CKBoxEditing from './ckboxediting'; | ||
| import type { TokenUrl } from '@ckeditor/ckeditor5-cloud-services/src/cloudservices'; |
There was a problem hiding this comment.
Move above local imports
| */ | ||
| async getAvailableCategories( offset = 0 ) { | ||
| public async getAvailableCategories( offset: number = 0 ): Promise<Array<{ |
There was a problem hiding this comment.
Consider creating a type for Category
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public static get requires(): ContextPluginDependencies { |
There was a problem hiding this comment.
Why not just PluginDependencies?
There was a problem hiding this comment.
CloudServices is a ContextPlugin, not a Plugin. Returning PluginDependencies would make it incompatible with PluginCollection used in Context.
| * | ||
| * Without a properly working token endpoint (token URL) CKEditor plugins will not be able to connect to CKEditor Cloud Services. | ||
| */ | ||
| tokenUrl: TokenUrl; |
There was a problem hiding this comment.
It's not optional on purpose?
Co-authored-by: Michał Remiszewski <118178939+mremiszewski@users.noreply.github.com>
…o ck/13005-ts-ckbox
mremiszewski
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (ckbox): Rewrite
ckeditor5-ckboxto TypeScript. Closes #13005.Other (cloud-services): Rewrite
ckeditor5-cloud-servicesto TypeScript. Closes #13007.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.