-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build packages to TypeScript #13463
Conversation
…-packages-to-typescript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsconfig
files are missing.
Please verify if any changes are needed in package.json
(s).
CC: @pomek |
Do you think it would work at all?
Webpack configuration should be aligned too. Also, I think the |
The |
We may want to publish typings for builds too.
Unfortunately, I am not sure if we go the right direction. |
Today we were discussing how we should publish typings and how other libraries do it. This will require further research, but AFAIK the approach you described is the most popular and the one I used in the past. Because we are already using webpack to build the package, we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the merge message. We do not convert html-support
.
LGTM.
Suggested merge commit message (convention)
Other (build-balloon): Rewrite
ckeditor5-build-balloon
into Typescript. Closes #13000.Other (build-balloon-block): Rewrite
ckeditor5-build-balloon-block
into Typescript. Closes #13001.Other (build-classic): Rewrite
ckeditor5-build-classic
into Typescript. Closes #13002.Other (build-decoupled-document): Rewrite
ckeditor5-build-decoupled-document
into Typescript. Closes #13003.Other (build-inline): Rewrite
ckeditor5-build-inline
into Typescript. Closes #13004.