Optional dropdownLimit property at a level of singular feed.
#13512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
requested changes
Feb 22, 2023
| @@ -239,7 +241,7 @@ export default class MentionUI extends Plugin { | |||
| const { item, marker } = data; | |||
|
|
|||
| // Set to 10 by default for backwards compatibility. See: #10479 | |||
| const dropdownLimit = this.editor.config.get( 'mention.dropdownLimit' ) || 10; | |||
| const dropdownLimit = data.dropdownLimit || this.editor.config.get( 'mention.dropdownLimit' ) || 10; | |||
There was a problem hiding this comment.
I think we don't need to pass the dropdownLimit all over the place. It would be much simpler (and would affect less code) if you would resolve the limit depending on the marker here. You could normalize the config to store limits for specific markers and just access this map here.
There was a problem hiding this comment.
I have extend the _mentionsConfigurations to pass there the dropdownLimit . I think thatthis is the right way 🙂
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
…e general option.
niegowski
approved these changes
Feb 22, 2023
niegowski
deleted the
ck/13504-add-dropdownlimit-at-a-level-of-singular-feed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (mention): Should be possible to limit the dropdown on singular feed level. Closes #13504 .
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.