Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: adding multi-root editor to predefined builds. #13557

Merged
merged 13 commits into from
Mar 10, 2023
Merged

Docs: adding multi-root editor to predefined builds. #13557

merged 13 commits into from
Mar 10, 2023

Conversation

godai78
Copy link
Contributor

@godai78 godai78 commented Feb 27, 2023

Suggested merge commit message (convention)

Docs: adding multi-root editor to predefined builds. Closes #13536.


Additional information

Only proceed after #13532 is merged.

@godai78 godai78 marked this pull request as draft February 27, 2023 08:15
@godai78 godai78 changed the title Docs: groundworks. Docs: adding multi-root editor to predefined builds. Feb 27, 2023
@godai78 godai78 marked this pull request as ready for review March 3, 2023 09:28
@godai78 godai78 requested a review from scofalik March 3, 2023 09:29
Copy link
Contributor

@scofalik scofalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note regarding the image. IIRC, in the example that I prepared, the bottom boxes shoud have the same height.

docs/installation/getting-started/predefined-builds.md Outdated Show resolved Hide resolved
Load the multi-root editor build (here, the [CDN](https://cdn.ckeditor.com/) location is used):

```html
<script src="https://cdn.ckeditor.com/ckeditor5/{@var ckeditor5-version}/multi-root/ckeditor.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure that it will be available on CDN :D. Who is responsible for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask Robert about it. I believe.

docs/installation/getting-started/predefined-builds.md Outdated Show resolved Hide resolved
docs/installation/getting-started/predefined-builds.md Outdated Show resolved Hide resolved
packages/ckeditor5-editor-multi-root/README.md Outdated Show resolved Hide resolved
@godai78 godai78 requested a review from scofalik March 6, 2023 08:25
@godai78
Copy link
Contributor Author

godai78 commented Mar 10, 2023

The recent push concerns cksource/ckeditor5-internal#2797

@scofalik scofalik merged commit 7f18ce5 into master Mar 10, 2023
@scofalik scofalik deleted the ck/13536 branch March 10, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multi root editor description to predefined builds section
2 participants