Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts-loader configs used in scripts #13615

Merged
merged 15 commits into from
Mar 8, 2023
Merged

Fix ts-loader configs used in scripts #13615

merged 15 commits into from
Mar 8, 2023

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Internal: Fix ts-loader configs used in scripts. Related to #13565.

@filipsobol filipsobol requested a review from pomek March 6, 2023 11:57
scripts/dll/webpack.config.dll.js Outdated Show resolved Hide resolved
scripts/docs/utils.js Outdated Show resolved Hide resolved
@filipsobol filipsobol requested a review from niegowski March 7, 2023 15:53
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, it looks good. I will take a few tests tomorrow before marking it as R+.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek
Copy link
Member

pomek commented Mar 8, 2023

image

@pomek pomek merged commit 6030c55 into master Mar 8, 2023
@pomek pomek deleted the ck/13565-fix-docs-builds branch March 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants