Style attribute conversion should work with attributeToAttribute()
#15688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): The
styleandclassattributes conversion should work withattributeToAttribute(). Closes #4517.MINOR BREAKING CHANGE (engine): In the
attributeToAttribute()upcast helper we fixed how the missingvalueof the"class"and"style"attribute conversion is handled. Now while not providing the attribute'svalueto the conversion helper accepts and consumes all values. Previously those values were not consumed and left for other converters to convert. Note that you should use theclasses, and thestylesfields for the fine-tuned conversion of those attributes instead of a catch-all"style"and"class"specified in thekeyfield.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.