Remove menu bar on editor destroy.

[mremiszewski]

Suggested merge commit message (convention)

Tests (editor-multi-root): Properly remove the menu bar element on editor destroy.

---

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

[coderabbitai]

Walkthrough

The update to the CKEditor5's multirooteditor.js enhances the cleanup process in the destroyEditor() function. This improvement includes the removal of both the toolbar and menu bar elements when an editor instance is destroyed, ensuring a more thorough cleanup and preventing potential memory leaks or UI clutter from residual elements.

Changes

File Path	Change Summary
.../ckeditor5-editor-multi-root/.../multirooteditor.js	Enhanced destroyEditor() to remove menuBarView.element in addition to toolbar.element.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 38a8f9c and 130c527.

Files selected for processing (1)

• packages/ckeditor5-editor-multi-root/tests/manual/multirooteditor.js (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Consider changing the order of operations in the destroyEditor function.

- editor.destroy()
-   .then( () => {
-     editor.ui.view.toolbar.element.remove();
-     editor.ui.view.menuBarView.element.remove();
-     window.editor = editor = null;
-     window.editables = null;
-     console.log( 'Editor was destroyed' );
-   } );
+ editor.ui.view.toolbar.element.remove();
+ editor.ui.view.menuBarView.element.remove();
+ editor.destroy()
+   .then( () => {
+     window.editor = editor = null;
+     window.editables = null;
+     console.log( 'Editor was destroyed' );
+   } );

The elements should be removed before calling editor.destroy() to ensure that all UI components are cleaned up before the editor instance is terminated. This helps prevent any potential issues that might arise if the editor's destruction process interferes with the removal of UI elements.

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	editor.ui.view.menuBarView.element.remove();
	editor.ui.view.toolbar.element.remove();
	editor.ui.view.menuBarView.element.remove();
	editor.destroy()
	.then( () => {
	window.editor = editor = null;
	window.editables = null;
	console.log( 'Editor was destroyed' );
	} );