Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tools guide updates #17122

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Dev tools guide updates #17122

merged 3 commits into from
Sep 19, 2024

Conversation

pomek
Copy link
Member

@pomek pomek commented Sep 19, 2024

Suggested merge commit message (convention)

Internal: Added a "Squash commits" section to the "Git commit message convention" guide.

Internal: Removed the --debug modifier from the "Running automated tests" section in the "Testing environment" guide as it is not supported after switching sources to TypeScript.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek pomek requested review from psmyrek and godai78 September 19, 2024 06:39
psmyrek
psmyrek previously approved these changes Sep 19, 2024
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

godai78
godai78 previously approved these changes Sep 19, 2024
Co-authored-by: Bartek Biedrzycki <68123541+godai78@users.noreply.github.com>
@pomek pomek dismissed stale reviews from godai78 and psmyrek via 3fdaccc September 19, 2024 06:56
@pomek pomek requested a review from psmyrek September 19, 2024 06:56
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek
Copy link
Member Author

pomek commented Sep 19, 2024

CI will likely fail due to selection changes in Chrome 129. See: #17113. As this PR updates only markdown files (docs), I will merge it anyway.

@pomek pomek merged commit 9efff53 into stable Sep 19, 2024
8 of 9 checks passed
@pomek pomek deleted the tools-docs-update branch September 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants