Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add default to exports entries in package.json files. #17675

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Dec 19, 2024

Suggested merge commit message (convention)

Internal: Add default to exports entries in package.json files. Fixes #17671.


In a few places in our tools, we use require instead of import to get data from packages. Instead of fixing all of them and potentially introducing breaking changes, it's easier to add a fallback default entry to the exports field.

pomek
pomek previously approved these changes Dec 19, 2024
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@filipsobol filipsobol merged commit c2705f4 into master Dec 19, 2024
10 checks passed
@filipsobol filipsobol deleted the fix-core-resolve branch December 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nightly docs
2 participants