Performance manual tests: inline css variant of fixtures #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extracted editor initialization as it will be reused and added several formatting plugins.
…is is very likely to change now.
|
No, that's not what I meant. Many means... many :D Like dozens per element. Various forms, some to be picked by the editor. Some not. Example – content copied in Chrome from some website. It usually has hundreds of inline styles on all kind of elements. A relatively good case was the markup we used for testing remove formatting, but it was too repetitive (would touch just one/two cases). Also, this is under "large HTML" so I don't understand why you proposed such a short content. |
|
@Reinmar didn't want to spend too much time on it in case there are any changes requested. I'll change it in that case. |
|
As mentioned in #6176 (comment) we decided to go with a bigger pull request instead of series of micro prs. This PR is merged there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Added inline css variant of fixtures for manual performance tests. See #5880.
Additional information
Note: I have added example styling only for one fixture, to make sure this is the right direction before we go with bigger fixtures. This way we'll avoid losing a lot of time in case we're looking for something else.