#6549: Adding a new row in the table copies structure of the selected row. #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
reviewed
May 7, 2020
# Conflicts: # packages/ckeditor5-table/src/commands/insertrowcommand.js # packages/ckeditor5-table/tests/commands/insertrowcommand.js
jodator
reviewed
May 14, 2020
There was a problem hiding this comment.
@niegowski Sorry for a longer review on this. I think that it would be better to make some calculations here a bit more straightforward. The way how -1 work here is hard to grasp. It do the job but it might require some time for others to dig into this code later on.
Check on some proposals below but anything less complicated is also welcome :)
jodator
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (table): Adding a new row in the table copies the structure of the selected row. Closes #6549.
Additional information