Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6679: The table properties button should not be enabled if all cell properties commands are disabled #6759

Merged
merged 2 commits into from
May 13, 2020

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Fix (table): The table properties button should not be enabled if all cell properties commands are disabled. Closes #6679.


Additional information

@niegowski niegowski changed the title The table properties button should not be enabled if all cell properties commands are disabled #6679: The table properties button should not be enabled if all cell properties commands are disabled May 7, 2020
@niegowski niegowski requested a review from jodator May 8, 2020 11:23
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niegowski I've just realised that this is only a half of this issue. Please copy the solution to TablePropertiesUI as the ticket was about both buttons AFAICS.

Apart of that :+1: .

@niegowski niegowski requested a review from jodator May 12, 2020 15:06
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1:

@jodator jodator merged commit 056e06e into master May 13, 2020
@jodator jodator deleted the i/6679 branch May 13, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table properties buttons miss isEnabled binding with commands
2 participants