#6260: Fixed triggering of table cell refreshing when multiple elements added in one differ #6779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
changed the title
jodator
approved these changes
May 11, 2020
There was a problem hiding this comment.
I was wondering what would happen if there will be multiple inserter into multiple table cells. But this change also work with this. Also such case feels a bit synthetic.
We can't just check if there are more than one child on any insertion as it would create more refresh than needed.
packages/ckeditor5-table/src/converters/table-cell-refresh-post-fixer.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): Fixed triggering of table cell refreshing when multiple elements added in one differ. Closes #6260.
Additional information