-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6190: Balloons attached to widgets should always be visible even if the widget is longer than a visible viewport #6810
Conversation
…etter position balloons around widgets that stick off the viewport.
…getToolbarRepository` plugin to improve the positioning of the toolbars.
… the `TablePropertiesUI` balloon around long widgets.
@ckeditor/qa-team Can you take a look at this? You can test both scenarios in http://fake.ckeditor.com:8125/ckeditor5-table/tests/manual/tableproperties.html using a very long table (or a very small viewport). |
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
…n of the balloon.
I guess I'm ready to live with that. |
I'm wondering about the scenario where editor is limited in height with |
That's a bigger topic because it touches all balloons, not only widget balloons. See #5328. |
Suggested merge commit message (convention)
Fix (widget): The widget toolbar should always be visible even if the widget is longer than a visible viewport (see #6190).
Fix (table): The table properties balloon should always be visible if the table is longer than a visible viewport. Closes #6190.
Additional information
centeredBalloonPositionForLongWidgets()
but there's so much going on in there I'm not sure there's an easy way to express that in simple words.centeredBalloonPositionForLongWidgets()
to be a part ofBalloonPanelView#defaultPositions
but I figured (so far) this is a widget-specific behavior so maybe let's keep it inckeditor5-widget
for a while.