Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6190: Balloons attached to widgets should always be visible even if the widget is longer than a visible viewport #6810

Merged
merged 12 commits into from
May 15, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented May 13, 2020

Suggested merge commit message (convention)

Fix (widget): The widget toolbar should always be visible even if the widget is longer than a visible viewport (see #6190).

Fix (table): The table properties balloon should always be visible if the table is longer than a visible viewport. Closes #6190.


Additional information

  • I'm not sure about the name of centeredBalloonPositionForLongWidgets() but there's so much going on in there I'm not sure there's an easy way to express that in simple words.
  • At first I wanted centeredBalloonPositionForLongWidgets() to be a part of BalloonPanelView#defaultPositions but I figured (so far) this is a widget-specific behavior so maybe let's keep it in ckeditor5-widget for a while.

oleq added 3 commits May 13, 2020 14:59
…etter position balloons around widgets that stick off the viewport.
…getToolbarRepository` plugin to improve the positioning of the toolbars.
… the `TablePropertiesUI` balloon around long widgets.
@oleq oleq requested a review from niegowski May 13, 2020 13:07
@oleq
Copy link
Member Author

oleq commented May 13, 2020

@ckeditor/qa-team Can you take a look at this? You can test both scenarios in http://fake.ckeditor.com:8125/ckeditor5-table/tests/manual/tableproperties.html using a very long table (or a very small viewport).

@FilipTokarski
Copy link
Member

FilipTokarski commented May 14, 2020

Desktop browsers & iOS work fine, but on Android the balloon appears halfway when scrolling up:

14_android_1

packages/ckeditor5-widget/src/utils.js Outdated Show resolved Hide resolved
packages/ckeditor5-widget/tests/utils.js Outdated Show resolved Hide resolved
oleq and others added 3 commits May 15, 2020 09:35
@oleq
Copy link
Member Author

oleq commented May 15, 2020

Desktop browsers & iOS work fine, but on Android the balloon appears halfway when scrolling up:

I guess I'm ready to live with that.

@niegowski
Copy link
Contributor

I'm wondering about the scenario where editor is limited in height with overflow: scroll. If editor would be in the middle of window, then this balloons would be displayed on the edge of the window (could be far away from editor), maybe we should try to stick it to closest scrollable instead of window?

@oleq
Copy link
Member Author

oleq commented May 15, 2020

I'm wondering about the scenario where editor is limited in height with overflow: scroll. If editor would be in the middle of window, then this balloons would be displayed on the edge of the window (could be far away from editor), maybe we should try to stick it to closest scrollable instead of window?

That's a bigger topic because it touches all balloons, not only widget balloons. See #5328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's no way to access table properties when table longer than the viewport
3 participants