Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6785 Table walker API change #6834

Merged
merged 14 commits into from
Jun 1, 2020
Merged

#6785 Table walker API change #6834

merged 14 commits into from
Jun 1, 2020

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented May 15, 2020

Suggested merge commit message (convention)

Other (table): TableWalker API rebuild. Closes #6785.

MINOR BREAKING CHANGE: The TableWalker API and yielded values change.


Additional information

@niegowski niegowski changed the title #6785 Table walker should handle startColumn and endColumn options #6785 Table walker API change May 29, 2020
@niegowski niegowski marked this pull request as ready for review May 29, 2020 16:27
@niegowski niegowski requested a review from jodator May 29, 2020 16:28
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1.

packages/ckeditor5-table/src/tablewalker.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablewalker.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablewalker.js Outdated Show resolved Hide resolved
@jodator jodator merged commit 65cfa13 into master Jun 1, 2020
@jodator jodator deleted the i/6785-table-walker-tuning branch June 1, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve TableWalker yielded options.
2 participants