Internal (ckeditor5): Fixed CC upload so that it works when CI job is reset #7260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (ckeditor5): Fixed CC upload so that it works when CI job is reset. Closes #7244.
Additional information
In a fascinating twist of reverse engineering and guessing I was able to get it working.
Unfortunately providing Coveralls token (suggested in Coveralls error message) didn't fix the problem.
I noticed a very strange thing, that our env
TRAVIS_JOB_IDis different than the job id in the Travis link… e.g. for https://travis-ci.org/github/ckeditor/ckeditor5/builds/689606488TRAVIS_JOB_IDwill be689606489.I wanted to force an unique job id, by making it e.g. a timestamp - but Coveralls backend was complaining that it could not match corresponding Travis build - so it means it has a special handling for Travis. So I checked the source code of
coverallsnpm package, to see how it determines whether it's Travis or not - turned out it should be based on the service name. So I adjusted the service name, and... it works 🧙♂️