Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7379: Trimming pasted content for table to table pasting. #7381

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Other (table): Pasting a table into a table is more tolerant for whitespaces around pasted table. Closes #7379.


Additional information

@niegowski niegowski requested a review from jodator June 4, 2020 15:48
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks about tests, other than that LGTM 👍 .

packages/ckeditor5-table/tests/tableclipboard-paste.js Outdated Show resolved Hide resolved
@niegowski niegowski requested a review from jodator June 5, 2020 09:24
@jodator
Copy link
Contributor

jodator commented Jun 5, 2020

@niegowski there was a comment about missing tests for "integration" test for something like: "p+p+table+p+br" but it got loast AFAICS - could you add it also?

@jodator jodator merged commit 669d54f into master Jun 5, 2020
@jodator jodator deleted the i/7379 branch June 5, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pasting a table into a table with empty elements around pasted table.
2 participants