#5866: To-do lists down-casting refactored #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
changed the title
jodator
suggested changes
Jul 7, 2020
| * @param {module:engine/view/element~Element} viewParent Tree view element in which we are looking for the position. | ||
| * @param {Number} expectedOffset Expected offset. | ||
| * @returns {module:engine/view/position~Position} Found position. | ||
| */ | ||
| _findPositionIn( viewParent, expectedOffset ) { | ||
| findPositionIn( viewParent, expectedOffset ) { |
There was a problem hiding this comment.
Requires some tests when opening as a publi API.
Comment on lines
109
to
119
| const direction = getLocalizedArrowKeyCodeDirection( domEventData.keyCode, editor.locale.contentLanguageDirection ); | ||
|
|
||
| editor.keystrokes.set( localizedJumpOverCheckmarkKey, ( evt, stop ) => jumpOverCheckmarkOnSideArrowKeyPress( stop, model ) ); | ||
| if ( direction != 'left' ) { | ||
| return; | ||
| } | ||
|
|
||
| if ( jumpOverCheckmarkOnSideArrowKeyPress( model ) ) { | ||
| domEventData.preventDefault(); | ||
| domEventData.stopPropagation(); | ||
| eventInfo.stop(); | ||
| } |
There was a problem hiding this comment.
Why not keep that in jumpOverCheckmarkOnSideArrowKeyPress() together:
this.listenTo( editing.view.document, 'keydown', getJumpOverCheckmarkOnSideArrowKeyPress( editor ) );
// or just editor.locale.contentLanguageDirection + editor.modelso, no returning Boolean and stopping event propagation outside.
There was a problem hiding this comment.
Yeah. Especially since now the method returns:
undefinedtruefalse
There's something strange and at least should be double checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (list): Editor should not crash on the enter key press inside a to-do list item containing soft-breaks. Closes #5866. Closes #6585.
Fix (list): Links inside a to-do list item should be properly converted to HTML. Closes #5779.
Feature (engine): Changed visibility scope of
Mapper#findPositionIn()fromprivatetopublic.Additional information