#7542: Widget type around UI should not be selectable by triple-click. #7599
Conversation
There was a problem hiding this comment.
Although this "solves" the issue, this is still a hack and the original issue (whatever it is) remains unsolved and could backfire in the future.
- For one thing, the engine should never allow the selection to cross the boundary of the figcaption (nested editable) in the first place. And the type around UI being outside the figcaption in DOM should never have an impact on how the figcaption works.
- Another thing is that the patch breaks the triple click functionality in FF (the third click selects the widget instead of the entire content of the nested editable).
I think we must dig deeper and figure out what happens on the native DOM level first to address the issue properly on the engine/widget level. This patch can only go as a last resort solution if we run out of ideas.
|
DOM Selection Ranges after triple-click:
View Ranges converted by
Model Ranges converted by
|
|
Also I noticed that |
…support and properly handle click on AttributeElement.
| const mapper = editor.editing.mapper; | ||
| const modelElement = mapper.toModelElement( element ); | ||
| const viewElement = element.is( 'attributeElement' ) ? | ||
| element.findAncestor( element => !element.is( 'attributeElement' ) ) : element; |
There was a problem hiding this comment.
What if there's a widget > nested editable > block-quote > link structure? Feels like viewElement will be the blockquote and the entire nested editable will not be selected. I think isInsideNestedEditable() could become getClosestNestedEditable() and you could re-use its output here.
There was a problem hiding this comment.
But in that situation entire content of that content editable would be selected instead of single paragraph.
There was a problem hiding this comment.
Note that table cells are also nested editables and triple-click action is expected to select current block only, not entire content editable.
There was a problem hiding this comment.
Can we have another test then that checks only the closest non-attribute is selected and not the entire nested editable?
Suggested merge commit message (convention)
Fix (widget): Triple-click inside image caption should not crash editor in Firefox. Closes #7542.
Fix (widget): Triple-click on link inside image caption should not crash editor in Safari. Closes #6021.
Additional information