-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLL - updated imports #8783
DLL - updated imports #8783
Conversation
…ing import paths.
This PR requires additional eslint rules:
In order to test everything, you need to clone additional repositories. Assuming, that your current working directory is set to
Then, on the |
@@ -16,10 +16,18 @@ export { default as Conversion } from './conversion/conversion'; | |||
|
|||
export { default as HtmlDataProcessor } from './dataprocessor/htmldataprocessor'; | |||
|
|||
export { default as InsertOperation } from './model/operation/insertoperation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding InsertOperation we should also add all other operations here.
So, my stance on this is that consistency is important. It will be confusing which packages use direct imports and which go via Therefore, I'd rather state it a bit differently: Every package that we have may only have three types of imports:
Therefore, it'd be great if you could research how much work would require to enforce this rule. I think it may require adding a few more things to packages' index files but other than that it seems doable. |
Oh, and one more thing – you can also consider my yesterday's finding that plugins that are part of the Essential plugin should be in the DLL. |
Suggested merge commit message (convention)
Internal: Updated import paths. See #8581.
Additional information
After merging the PR, remember about adding the note below to the list of breaking changes here – #8614 (comment).