-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a placeholder for not previewable HTML snippet. #8799
Conversation
@oleq Sinc it's totally different solution than the one we discussed, I'd like to wait for some initial review before writing the tests. |
The current state is as follows: |
@@ -8,6 +8,8 @@ | |||
--ck-html-embed-source-height: 10em; | |||
--ck-html-embed-unfocused-outline-width: 1px; | |||
--ck-html-embed-content-min-height: calc(var(--ck-icon-size) + var(--ck-spacing-standard)); | |||
|
|||
--ck-html-embed-source-disabled-color: hsl(0deg 0% 45%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable is added to be consistent with not merged yet https://github.com/ckeditor/ckeditor5/pull/8818/files, which also fixed the contrast ratio.
Suggested merge commit message (convention)
Fix (html-embed): An information should be displayed if the HTML snippet is not previewable. Closes #8435.