Fixed content not restored on undo when multiple blocks and widgets were removed #8872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
commented
Jan 20, 2021
| @@ -78,7 +78,7 @@ describe( 'transform', () => { | |||
|
|
|||
| john.undo(); | |||
| syncClients(); | |||
| expectClients( '<paragraph>Foo</paragraph><paragraph>Bar</paragraph><paragraph></paragraph>' ); | |||
| expectClients( '<paragraph>Foo</paragraph><paragraph></paragraph><paragraph>Bar</paragraph>' ); | |||
There was a problem hiding this comment.
The old expectation was incorrect (worse UX wise) than the new one. The new expectation actually returns to the state before any changes...
|
@ckeditor/qa-team Please please check :) Please check scenarios invloving merges/splits, other actions and undo. |
niegowski
reviewed
Feb 2, 2021
|
We've tested it and looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): Fixed content not restored on undo when multiple blocks and widgets were removed. Closes #8870.