Add Linux Mips support #16
Conversation
.github/workflows/release.yaml
Outdated
| ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.MAVEN_CENTRAL_USERNAME }} | ||
| ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.MAVEN_CENTRAL_PASSWORD }} | ||
| ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_KEY }} | ||
| run: ./gradlew build publishMips -x check |
There was a problem hiding this comment.
I'm not sure I'd bother with running build (and needing to exclude check) here.
I think instead we make this job depend on the other one so that we know build has already succeeded and we are only concerned with publishing these two targets.
There was a problem hiding this comment.
If you want to split the jobs, we need to cache the build artifact from the other job (we are not doing step both run in 2 independent containers), which is more effort. (I did that here and you will need this as well to understand it).
The check we can skip since a) it did run already with MacOS and b) the container will not execute the tests since it does not run on MIPS.
There was a problem hiding this comment.
Ah, looks like you already have the needs: publish. I must have missed it first time around because I was reviewing on mobile. My bad. That's all I was saying we needed.
So yeah the only thing left is why do build publishMips -x check instead of only publishMips?
There was a problem hiding this comment.
My bad...you are absolutely right.
build.gradle.kts
Outdated
| linuxX64() | ||
| linuxMips32() | ||
| linuxMipsel32() |
There was a problem hiding this comment.
| linuxX64() | |
| linuxMips32() | |
| linuxMipsel32() | |
| linuxMips32() | |
| linuxMipsel32() | |
| linuxX64() |
(The current list is alphabetized)
There was a problem hiding this comment.
Well, kinda. I see I put 32 after 64 above 🙈
There was a problem hiding this comment.
Done (if I got it correctly)
bitPogo
force-pushed
the
feature/add-linuxmips
branch
2 times, most recently
from
77249a7 to
9ebdb08
Compare
|
You accidentally checked in a |
bitPogo
force-pushed
the
feature/add-linuxmips
branch
from
9ebdb08 to
912e1c5
Compare
build.gradle.kts
Outdated
| linuxMips32() | ||
| linuxMipsel32() | ||
| linuxArm64() |
There was a problem hiding this comment.
Now Arm64 comes after Arm32 👍 In total I'm not sure this new list is an improvement when it comes to alphabetical ordering, though 😉
There was a problem hiding this comment.
Tell me what you prefer
build.gradle.kts
Outdated
| linuxMips32() | ||
| linuxMipsel32() | ||
| linuxArm64() |
There was a problem hiding this comment.
| linuxMips32() | |
| linuxMipsel32() | |
| linuxArm64() | |
| linuxArm64() | |
| linuxMips32() | |
| linuxMipsel32() |
bitPogo
force-pushed
the
feature/add-linuxmips
branch
from
912e1c5 to
91ad47a
Compare
bitPogo
force-pushed
the
feature/add-linuxmips
branch
from
91ad47a to
7bb4def
Compare
|
Thanks 👍 |
|
I thank you for the effort! |
No description provided.