Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Bring the code into compliance with Google Python Style Guide #3

Open
spbnick opened this issue Mar 8, 2018 · 2 comments
Open

Bring the code into compliance with Google Python Style Guide #3

spbnick opened this issue Mar 8, 2018 · 2 comments
Labels
good first issue Good for newcomers

Comments

@spbnick
Copy link
Contributor

spbnick commented Mar 8, 2018

Make the code comply with Google Python Style Guide, where possible. Where not possible, document exceptions or additions. Document our compliance and requirements for contributions. Proceed gradually. Add pylint checking to CI runs.
@agustinhenze agustinhenze mentioned this issue Mar 13, 2018
Closed
@veruu
Copy link
Contributor

veruu commented May 10, 2018 •
edited
Loading

  • Documentation for requirements in contribution guide, linking to meta/coding
  • Whole repository is pycodestyle compliant
  • Tests are pylint compliant
  • Whole repository is pylint compliant

major added a commit that referenced this issue May 15, 2018
@major @spbnick
Add tests directory
caab546 
This patch adds a `tests` directory to `sktm` which allows ut to work
on #3.

Signed-off-by: Major Hayden <major@redhat.com>
This was referenced May 21, 2018
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@danghai danghai mentioned this issue May 22, 2018
Merged
@veruu
Copy link
Contributor

veruu commented May 22, 2018

GitHub seems to think every pull request working toward this fixes the issue and automatically closes it with the merge so reopening it.

@veruu veruu reopened this May 22, 2018
@veruu veruu added the good first issue Good for newcomers label Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spbnick @veruu