Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CiReleaseModule.setupGpg public #62

Merged
merged 1 commit into from
May 1, 2023

Conversation

alexarchambault
Copy link
Contributor

I've been having issues setting up gpg with the way it's done currently here. This PR makes the setupGpg method public, so that users can override it to something else (to debug it say) or to a no-op.

I've been having such an error here in this build, which gives

Attempting to setup gpg
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0

in spite of an early manual command with the same inputs, giving

gpg: key 337EBD9967C97AC9: public key "" imported
gpg: key 337EBD9967C97AC9: secret key imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg:       secret keys read: 1
gpg:   secret keys imported: 1

@alexarchambault
Copy link
Contributor Author

alexarchambault commented May 1, 2023

IIRC, sbt-ci-release doesn't fail when it tries to import GPG data (I don't recall that happening at least, it rather fails later when trying to sign artifacts).

@ckipp01
Copy link
Owner

ckipp01 commented May 1, 2023

IIRC, sbt-ci-release doesn't fail when it tries to import GPG data (I don't recall that happening at least, it rather fails later when trying to sign artifacts).

Huh, I'd assume that whatever the behavior is there, it should be the same here. When I ported this I pretty much copied it verbatim.

I'm surprised by that error you're getting as I haven't seen it anywhere else. Either way, I think this is totally fine.

@ckipp01 ckipp01 merged commit 5c6f659 into ckipp01:main May 1, 2023
@ckipp01
Copy link
Owner

ckipp01 commented May 1, 2023

This should produce a snapshot in https://github.com/ckipp01/mill-ci-release/actions/runs/4852495003 that you can test with.

@alexarchambault alexarchambault deleted the public-setup-gpg branch May 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants