Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Beam Threshold #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changed Beam Threshold #23

wants to merge 4 commits into from

Conversation

CatarinaSilva
Copy link

  • The older expression (before May) was comparing probabilities with logarithms, and although this was fixed with the previous commit the expression should be a sum and not a multiplication, to keep the same meaning.
  • Also, multiplying the beam threshold with the log(10) factor turns the parameter more intuitive
  • The default threshold also makes more sense with this expression

@tomaspinho
Copy link

@redpony comments on this are deeply appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatarinaSilva @tomaspinho @andre-martins