修改一些问题 #21
Open
修改一些问题 #21
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2018 16:41
AngusFu
reviewed
Sep 11, 2018
| @@ -15,7 +15,8 @@ export default { | |||
| validateThrottle: { | |||
| type: Number, | |||
| default: 0 | |||
| } | |||
| }, | |||
| skipValidate: Boolean | |||
There was a problem hiding this comment.
建议遵守“动词+名词”的命名规则。skip 和 validate 都是动词。
PS ——
validateThrottle这个属性，“名词+动词”，很拗口，以后尽量避免。- 怎么解决这个问题呢？
validateThrottleTime太长，throttleTime似乎又不能完全体现其作用。所以，是不是把所有和validate这一行为相关的属性，统一到一个 Object 下面更好？
AngusFu
reviewed
Sep 11, 2018
| @@ -502,7 +505,9 @@ export default { | |||
|
|
|||
| emitChange () { | |||
| const value = this.multiple ? this.selectedValues : this.selectedValues[0] | |||
| this.$emit('change', value) | |||
| const label = this.multiple ? this.selectedLabel : this.selectedLabel[0] | |||
| console.log(value, label) | |||
|
@hanyonggang 另外，对你的 commit message 提出一些建议 ——
所以说，写 commit message 也是一个思（tong）考（ku）的过程。commit message 也算是一个项目的脸面之一，�开源项目，脸得好看。另外一方面，清晰的 commit message 能让人看懂你的修改到底干了些什么。其他就不一一说明了。 以上是一些不成熟的思考、意见。 再 PS 下，建议 google 下如何修改 commit message，学会将受用不尽。 |
AngusFu
reviewed
Sep 11, 2018
src/entry.js
Outdated
| @@ -2,7 +2,7 @@ import { Clair } from './scripts' | |||
| // import './styles/entry.css' | |||
|
|
|||
| if (typeof window !== 'undefined' && window.Vue) { | |||
| // window.Vue.use(Clair) | |||
| window.Vue.use(Clair) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.在validate的mixin中添加对于组件验证的跳过功能
2.各种输入框在onChange时在之前返回一个val的基础上多返回一个label