Skip to content

Reinstate no randomize layout #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Reinstate no randomize layout #39

wants to merge 12 commits into from

Conversation

connorkuehl
Copy link

@connorkuehl connorkuehl commented Feb 28, 2019 •
edited
Loading

Closes #6
Closes #15
Closes #37

[100%] Running the Clang regression tests     
llvm-lit: /home/kuehlcon/llvm-project/llvm/utils/lit/lit/llvm/config.py:337: note: using clang: /home/kuehlcon/llvm-project/build/bin/clang
Testing Time: 427.60s                                                                    
  Expected Passes    : 14089                                                                         
  Expected Failures  : 19                                                                           
  Unsupported Tests  : 62                                                 
[100%] Built target check-clang                                              
[100%] Built target clang-test

Jafosterja and others added 12 commits February 23, 2019 00:37
@Jafosterja
Added basic implementation of auto selection for strucutres of only f…
e0cfd8a 
…unction pointers
@Jafosterja
Refactored the auto selection code
6fedc9d
@Jafosterja
Added comments
63cf353
merging changes from develop
e33d38e
@Jafosterja
Removed unnecessary functions
b4446bd
adding flag
0a9f695
@connorkuehl
Merge branch 'develop' into randstruct-auto
dd7a572
@connorkuehl
Add -randstruct-auto command line argument
3e53f43
@Jafosterja
Refactored code for better readability
97166c8
@connorkuehl
Merge branch 'randstruct-auto' into Autoselect
a8106ca
@connorkuehl
Delete NoRandomizeLayout check
2a220f2 
This will be checked at our entry point, so we don't
need to check this here.
@connorkuehl @Nixoncole @jeffreytakahashi
Revert deletion of no_randomize_Layout code
cd48dc2 
This reverts commits
	* f06d4cc.
	* 9949798.

Co-Authored-By: Cole Nixon <nixontcole@gmail.com>
Co-Authored-By: Jeff Takahashi <jeffrey.takahashi@gmail.com>
@connorkuehl connorkuehl force-pushed the reinstate-no-randomize-layout branch from 54419de to cd48dc2 Compare February 28, 2019 01:46
@connorkuehl
Copy link
Author

Here's the proper diff since I had created this PR branching off of another PR (which has already landed, so we're good, otherwise I'd rebase if neededD).

Nixoncole
Nixoncole approved these changes Mar 1, 2019
View reviewed changes
Copy link

@Nixoncole Nixoncole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the resurrection. Looks good!

jeffreytakahashi
jeffreytakahashi approved these changes Mar 1, 2019
View reviewed changes
Copy link

@jeffreytakahashi jeffreytakahashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connor the necromancing champion. Looks solid to me.

@connorkuehl
Copy link
Author

Did a rebase and merged in manually in 54226c7

@connorkuehl connorkuehl closed this Mar 1, 2019
This was referenced Mar 1, 2019
Closed
Closed
Closed
@connorkuehl connorkuehl deleted the reinstate-no-randomize-layout branch July 6, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreytakahashi jeffreytakahashi jeffreytakahashi approved these changes

@Jafosterja Jafosterja Awaiting requested review from Jafosterja

@jcantrell jcantrell Awaiting requested review from jcantrell

@nforbus nforbus Awaiting requested review from nforbus

@Nixoncole Nixoncole Awaiting requested review from Nixoncole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorkuehl @Nixoncole @jeffreytakahashi @Jafosterja