Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation of clangd binaries if not found. #43

Merged
merged 4 commits into from
May 6, 2020

Conversation

sam-mccall
Copy link
Member

Also has auto-update checks, but turned off by default for now.

See:

Also has auto-update checks, but turned off by default for now.

See:
- Library with main logic: clangd/node-clangd@3ce82ac
- PR for vscode-clangd: clangd/vscode-clangd#5
@sam-mccall sam-mccall requested review from fannheyward and hokein May 5, 2020 15:58
Copy link

@hokein hokein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good from my side.

@fannheyward
Copy link
Member

I make two small commits:

  1. @clangd/install as devDependencies, this will bundle all dependencies by webpack, to a single lib/index.js file.
  2. run editor.action.restart after download, no more :CocRestart needed.

@fannheyward fannheyward merged commit 8dff283 into master May 6, 2020
@oblitum
Copy link

oblitum commented May 6, 2020

Just missed an update to README which states this is not supported.

@oblitum
Copy link

oblitum commented May 6, 2020

Will this grab clangd from prereleases as well or just releases?

Another question is if I enable this will it override my system installation correctly (since clangd comes bundled to clang)?

fannheyward added a commit that referenced this pull request May 6, 2020
@fannheyward fannheyward deleted the autoinstall branch May 6, 2020 03:45
@fannheyward
Copy link
Member

@oblitum
Copy link

oblitum commented May 6, 2020

@fannheyward ah, ok, thanks!

@fannheyward
Copy link
Member

@sam-mccall @hokein this will update clangd.path in coc-settings.json?

@sam-mccall
Copy link
Member Author

@fannheyward Thanks! LGTM

this will update clangd.path in coc-settings.json?

Correct, it'll install a portable clangd (just unzip the release) under ~/.config/coc/extensions/coc-clangd-data/install/, and then update coc's clangd.path setting to point to it. The rest of the system is not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants