Trigger signature help when accepting code completions, where appropriate #398
Conversation
…iate. As recommended in microsoft/vscode#78806 This is an incomplete fix but better than nothing. Also files microsoft/vscode#164310 in case VSCode can improve the behavior here. fixes clangd#390
| // They say a plugin should trigger this, but LSP has no mechanism. | ||
| // https://github.com/microsoft/language-server-protocol/issues/274 | ||
| // (This workaround is incomplete, and only helps the first param). | ||
| if (item.insertText instanceof vscode.SnippetString && |
There was a problem hiding this comment.
Is it intentional that the workaround is not reached if the user has set "clangd.serverCompletionRanking": false (which causes us to early-return near the top of this function)?
There was a problem hiding this comment.
(The likely answer here is that there's no reason the workaround couldn't also apply to the "clangd.serverCompletionRanking": false case, we'd just have to reorganize the code a bit to handle that case as well. We can do that in a follow-up patch if anyone asks for it.)
|
This patch has been reviewed and approved, with no further activity on it for over a year. I'm not aware of any outstanding concerns about it. (I remain curious about the question I asked, but it's not an issue that needs to block the patch.) I'm going to go ahead and merge this. |
3 participants
As recommended in microsoft/vscode#78806 This is an incomplete fix but better than nothing. Also files microsoft/vscode#164310 in case VSCode can improve the behavior here.
fixes #390