Skip to content

Commit

Permalink
Remove some defaults from profiles
Browse files Browse the repository at this point in the history
  • Loading branch information
pksunkara committed Apr 10, 2020
1 parent bf65ef3 commit b45746f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,8 @@ unstable = ["clap_derive/unstable"] # for building with unstable clap feature
debug = ["clap_derive/debug"] # Enables debug messages
doc = ["yaml"] # All the features which add to documentation

[profile.dev]
codegen-units = 4

[profile.test]
opt-level = 1
debug = true
codegen-units = 4

[profile.bench]
lto = true

This comment has been minimized.

Copy link
@CreepySkeleton

CreepySkeleton Apr 10, 2020

Contributor

Note to myself: reevaluate usefulness of lto once we have reliable benches. It doesn't do much more than ThinLTO these days but increases compilation time by 2x and more.

Expand Down
1 change: 1 addition & 0 deletions clap_derive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,4 @@ doc = []

[package.metadata.docs.rs]
features = ["doc"]
targets = ["x86_64-unknown-linux-gnu"]
1 change: 1 addition & 0 deletions clap_generate/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@ doc = []

[package.metadata.docs.rs]
features = ["doc"]
targets = ["x86_64-unknown-linux-gnu"]

1 comment on commit b45746f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b45746f Previous: 20a7418 Ratio
build_empty 89 ns/iter (± 2) 94 ns/iter (± 4) 0.95
parse_empty 924 ns/iter (± 30) 878 ns/iter (± 37) 1.05
parse_simple_with_complex 3331 ns/iter (± 99) 3748 ns/iter (± 151) 0.89
parse_simple_with_pos 2738 ns/iter (± 76) 2522 ns/iter (± 67) 1.09
parse_simple_with_opt 3176 ns/iter (± 76) 2854 ns/iter (± 100) 1.11
parse_simple_with_flag 2562 ns/iter (± 79) 2619 ns/iter (± 105) 0.98
build_with_pos_ref 210 ns/iter (± 7) 215 ns/iter (± 6) 0.98
build_with_pos 153 ns/iter (± 3) 165 ns/iter (± 7) 0.93
build_with_opt_ref 329 ns/iter (± 9) 290 ns/iter (± 8) 1.13
build_with_opt 245 ns/iter (± 7) 258 ns/iter (± 8) 0.95
build_with_flag_ref 286 ns/iter (± 9) 239 ns/iter (± 7) 1.20
build_with_flag 214 ns/iter (± 5) 219 ns/iter (± 10) 0.98
build_simple 701 ns/iter (± 18) 664 ns/iter (± 30) 1.06
build_from_usage 3970 ns/iter (± 106) 4413 ns/iter (± 158) 0.90
build_from_builder 2288 ns/iter (± 75) 2278 ns/iter (± 87) 1.00
build_from_macros 2336 ns/iter (± 74) 2313 ns/iter (± 74) 1.01
parse_complex 6844 ns/iter (± 297) 6558 ns/iter (± 183) 1.04
parse_complex_with_flag 7534 ns/iter (± 315) 7417 ns/iter (± 172) 1.02
parse_complex_with_opt 7807 ns/iter (± 226) 8176 ns/iter (± 313) 0.95
parse_complex_with_pos 7645 ns/iter (± 329) 8028 ns/iter (± 190) 0.95
parse_complex_with_sc 10149 ns/iter (± 476) 9295 ns/iter (± 299) 1.09
parse_complex_with_sc_flag 10500 ns/iter (± 314) 11218 ns/iter (± 334) 0.94
parse_complex_with_sc_opt 10313 ns/iter (± 427) 11287 ns/iter (± 334) 0.91
parse_complex_with_sc_pos 9765 ns/iter (± 339) 11021 ns/iter (± 498) 0.89
parse_complex1 15264 ns/iter (± 507) 13213 ns/iter (± 518) 1.16
parse_complex2 15941 ns/iter (± 397) 14376 ns/iter (± 635) 1.11
parse_args_negate_scs 15532 ns/iter (± 748) 14565 ns/iter (± 680) 1.07
parse_complex_with_sc_complex 12635 ns/iter (± 424) 10698 ns/iter (± 297) 1.18
example1 16565 ns/iter (± 398) 15713 ns/iter (± 526) 1.05
example2 353548 ns/iter (± 35152) 368027 ns/iter (± 39940) 0.96
example3 16414 ns/iter (± 484) 17109 ns/iter (± 556) 0.96
example4 11014 ns/iter (± 306) 11572 ns/iter (± 283) 0.95
example5 446973 ns/iter (± 33824) 447857 ns/iter (± 36214) 1.00
example6 9382 ns/iter (± 284) 8259 ns/iter (± 271) 1.14
example7 13234 ns/iter (± 286) 12824 ns/iter (± 449) 1.03
example8 12393 ns/iter (± 536) 12197 ns/iter (± 443) 1.02
example10 406043 ns/iter (± 35519) 421202 ns/iter (± 41412) 0.96
example4_template 9936 ns/iter (± 236) 10760 ns/iter (± 523) 0.92
build_rg_with_short_help 10371 ns/iter (± 282) 11384 ns/iter (± 479) 0.91
build_rg_with_long_help 11063 ns/iter (± 619) 11630 ns/iter (± 430) 0.95
write_rg_short_help 99783 ns/iter (± 3458) 89671 ns/iter (± 1993) 1.11
write_rg_long_help 228295 ns/iter (± 8664) 210640 ns/iter (± 8000) 1.08
parse_rg 23310 ns/iter (± 725) 23440 ns/iter (± 719) 0.99
parse_rg_with_complex 35674 ns/iter (± 1137) 33206 ns/iter (± 960) 1.07
parse_rg_with_lots 748218 ns/iter (± 16190) 723127 ns/iter (± 19352) 1.03
build_rustup 12141 ns/iter (± 422) 11965 ns/iter (± 340) 1.01
parse_rustup 16284 ns/iter (± 408) 16877 ns/iter (± 587) 0.96
parse_rustup_with_sc 17199 ns/iter (± 950) 16736 ns/iter (± 886) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.