upgrading to 4.1 (version, color, multiple_values)

[nbari]

I have this working code using version 3 and wanted to give a try to version 4, the first thing I notice is that if I remove the version by using .disable_version_flag(true) I don't get anymore the version printed in next to the app name, for example with version 3 I get:

gbump 1.0.7

With version 4 I don't get the name, just the Usage text directly

Usage: gbump [OPTIONS] [version]

I also found that there are no more colors, Now I get text underlined, and when trying to use use clap::{Arg, ColorChoice, Command}; and in Cargo.toml this:

clap = { version = "4", features = ["color"] }

And:

let matches = Command::new("gbump")
        .version(env!("CARGO_PKG_VERSION"))
        .color(ColorChoice::Always)

Still get the underline text and no colors.

But I am getting lost trying to adapt this:

    Arg::with_name("version")
                .takes_value(false)
                .default_value("patch")
                .possible_value("major")
                .possible_value("minor")
                .possible_value("patch"),

...

 let mut semver = String::new();
    if !matches.is_present("quiet") {
        semver.push_str(format!("{}.{}.{} --> ", major, minor, patch).as_str());
    };

I am trying:

  Arg::new("version")
      .default_value("patch")
      .value_parser(["major", "minor", "patch"]),
 ...

   let mut semver = String::new();
    if !matches.get_flag("quiet") {
        semver.push_str(format!("{}.{}.{} --> ", major, minor, patch).as_str());
    };

If I run it I get:

thread 'main' panicked at 'ArgAction::SetTrue / ArgAction::SetFalse is defaulted', src/main.rs:64:17

Any ideas?

[epage]

As a heads up, most of this will be covered by the CHANGELOG.md and the release announcement

I don't get anymore the version printed in next to the app name, for example with version 3 I get:

With version 4 I don't get the name, just the Usage text directly

These are removed from the default help template as they didn't provide enough value to justify the vertical space being taken up. #4132 includes or links out to the related discussions on this and workarounds on how to get the old behavior (hint Command::help_template and the docs for it include the old template)

I also found that there are no more colors, Now I get text underlined,

#4132 is again the place to check out more information on this. #3234 will allow theming and is one of m,y focus areas right now. Until then, you can either use the styling available, not upgrade yet, or disable styling.

As for color feature flag and ColorChoice, when we saw "color" in CLIs, it is usually short-hand for all terminal styling.

But I am getting lost trying to adapt this:

The CHANGELOG includes a migration guide. I highly recommend following it. Changes like this can and should be made before upgrading as it allows you to incrementally upgrade and verify your application.

thread 'main' panicked at 'ArgAction::SetTrue / ArgAction::SetFalse is defaulted', src/main.rs:64:17

I'm assuming that panic is pointing to get_flag("quiet"). To answer your question on this, I would need to see the new definition of quiet

[nbari]

Hi @epage, thanks I will check the Changelog, regarding the definition for quiet:

        .arg(
            Arg::with_name("quiet")
                .required(false)
                .takes_value(false)
                .long("quiet")
                .short('q')
                .help("Prints only the next SemVer not the current one"),
        )

[epage]

Change that to

        .arg(
            Arg::with_name("quiet")
                .long("quiet")
                .short('q')
                .action(ArgAction::SetTrue)
                .help("Prints only the next SemVer not the current one"),
        )

then it should work with get_flag.

[nbari]

Thanks, I will stay with version 3 for now

[epage]

FYI clap's default terminal styling (colors) is being revisited in #5881.