-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fish completion fails with nested subcommands #685
Comments
Note that our completion support is incomplete pending solutions for these two issues: clap-rs/clap#568 clap-rs/clap#685
Thanks for fiiling this! I'll start looking into it and report back with what I find. |
cc @wdv4758h |
I can try to fix it, but the progress may be slow, since I'm fulfilling my country's mandatory military service. |
I have fixed it! @emk here is the new result for cage's
|
fix(Completions): fish completions for nested subcommands Fix #685
fix(Completions): fish completions for nested subcommands Fix #685
@wdv4758h I can confirm that this fix works great! Thank you for taking time during your military service to implement this patch. |
Has this regressed since it was implemented? I'm using
and not what is mentioned here (`-n '__fish_using_command cage generate help') |
yes it had, I made a new issue over here #2715 |
cage has nested subcommands:
The top-level subcommands complete fine under fish:
But second-level subcommands fail:
Using the generated bash completion, this works correctly:
I don't have time to dig into this right now, but I hope that because it already works with one shell, it's just a simple fix for the other.
The text was updated successfully, but these errors were encountered: