fix(#1374): Remove all values from previous occurrences on self-override #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-override When an argument gets self-overriden, at most a single value gets kept from the existing values list. This is incorrect when the argument has multiple values per occurrence, and makes for "funny" bugs such as `--input a b --input c d` being parsed as `--input d`. This patch fixes the issue by keeping track of how many values were already present when we started parsing each occurrence, and removing all the values but the ones for the last occurrence when a self-override occurs.
|
@Elarnon this was autoclosed when v3-master became master. If still interested please rebase onto master 😄 |
|
Given that in almost a year nobody looked at the patch or expressed that #1374 was also an issue for them, and that I am not using those features of clap currently, I will let this go. If someone else wants to rebase they are welcome to do so. Thank you for checking in on this PR, and congrats on the progress on v3 -- it looks like the end of the road is near! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an argument gets self-overriden, at most a single value gets kept
from the existing values list. This is incorrect when the argument has
multiple values per occurrence, and makes for "funny" bugs such as
--input a b --input c dbeing parsed as--input d.This patch fixes the issue by keeping track of how many values were
already present when we started parsing each occurrence, and removing
all the values but the ones for the last occurrence when a self-override
occurs.