Consistently wrap help and subcommand messages(with refactoring) #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldm0
changed the title
pksunkara
requested changes
Oct 21, 2020
ldm0
force-pushed
the
wrap_help
branch
2 times, most recently
from
8ebb6a3
to
3aa89ce
Compare
ldm0
force-pushed
the
wrap_help
branch
3 times, most recently
from
1ec60b1
to
bf61169
Compare
|
Done. Now it's easier to review. (Relatively XD) |
pksunkara
approved these changes
Oct 25, 2020
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
2 tasks
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2170
First commit and the third refactored the arg writing and subcomand writing without changing clap's behaviour. Which is needed because I think these code is a bit rotten(unnecessary side effects occurred in output functions).
Second commit introduces the help message wrap checking(refractoring above make proving the wrap checking's correctness a lot easier).