Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file include #2568

Closed
wants to merge 2 commits into from
Closed

fix file include #2568

wants to merge 2 commits into from

Conversation

tshepang
Copy link
Contributor

@tshepang tshepang commented Jul 3, 2021 •
edited
Loading

compiler output

  warning: unknown `doc` attribute `include`
   --> /home/tshepang/clap/src/lib.rs:9:8
    |
  9 | #![doc(include = "../README.md")]
    | -------^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../README.md")]`
    |
    = note: `#[warn(invalid_doc_attributes)]` on by default
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730>

@tshepang
fix file include
c01ad66 
compiler output

  warning: unknown `doc` attribute `include`
   --> /home/tshepang/clap/src/lib.rs:9:8
    |
  9 | #![doc(include = "../README.md")]
    | -------^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../README.md")]`
    |
    = note: `#[warn(invalid_doc_attributes)]` on by default
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #82730 <rust-lang/rust#82730>
@tshepang
use notation that works on current stable (v1.53)
332c4e5 
Notation on parent commit will probably be available only on Rust v1.55
@tshepang
Copy link
Contributor Author

tshepang commented Jul 3, 2021

not working for some reason :(

@tshepang tshepang closed this Jul 3, 2021
@tshepang tshepang deleted the fix-file-include branch July 3, 2021 21:17
@pksunkara
Copy link
Member

Yup, when 1.54 is out, we should bump MSRV and fix it.

@pksunkara pksunkara mentioned this pull request Jul 25, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshepang @pksunkara