Revert "Automatically read license field from Cargo.toml" #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6898fbd. PR clap-rs#2144 added the `license` field but no consumer has been added since the (like Issue clap-rs#1768). Since this is not ready yet, I am pulling it from the 3.0 release. So far, our main route for pulling a feature from the release has been to put it behind a `unstable-*` feature flag and to create a stablization tracking issue. I chose to instead remove the feature because a write-only field with no effect does not provide values for people to use in as an early access and so doesn't outweight the cost of the extra documentation noise and code noise it creates. Additionally, keeping an `unstable-` feature around when it has such an unknown path (and time table) to stalbization feels like it violates YAGNI. I'm uncertain how much of this feature we can implement and not create a legal trap for users because the crate's license is insufficient for the final artifact's license. I feel our stabliazation process sshould be about iteration and collecting user feedback which this doesn't line up with. When someone is ready to tackle clap-rs#1768, it will be easy to revert this commit and pick up the work again. Fixes clap-rs#3001
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6898fbd.
PR #2144 added the
licensefield but no consumer has been added sincethe (like Issue #1768). Since this is not ready yet, I am pulling it
from the 3.0 release.
So far, our main route for pulling a feature from the release has
been to put it behind a
unstable-*feature flag and to create astablization tracking issue. I chose to instead remove the feature
because a write-only field with no effect does not provide values for
people to use in as an early access and so doesn't outweight the cost of
the extra documentation noise and code noise it creates. Additionally,
keeping an
unstable-feature around when it has such an unknown path(and time table) to stalbization feels like it violates YAGNI. I'm
uncertain how much of this feature we can implement and not create a
legal trap for users because the crate's license is insufficient for the
final artifact's license. I feel our stabliazation process sshould be
about iteration and collecting user feedback which this doesn't line up
with.
When someone is ready to tackle #1768, it will be easy to revert this
commit and pick up the work again.
Fixes #3001