Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(complete): Fix imports in documentation #3243

Merged
merged 1 commit into from
Jan 3, 2022
Merged

docs(complete): Fix imports in documentation #3243

merged 1 commit into from
Jan 3, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Jan 2, 2022

Use shells::Bash instead of generators::Bash

@intgr intgr changed the title Fix imports in clap_complete documentation docs(complete): Fix imports in documentation Jan 2, 2022
@intgr
docs(complete): Fix imports in documentation
f10c5d1 
Use `shells::Bash` instead of `generators::Bash`
@intgr intgr force-pushed the fix-clap_complete-documentation-imports branch from 1f95402 to f10c5d1 Compare January 2, 2022 19:10
@intgr
Copy link
Contributor Author

intgr commented Jan 2, 2022

PS: Congratulations for reaching the clap 3.0 milestone and thanks for your hard work! :)

epage
epage approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I really dislike ignore in examples. Will need to probably revisit these at some point to fix that.

@epage epage merged commit 06f24b1 into clap-rs:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @epage