Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clap_complete: Pass a list to __fish_seen_subcommand_from #5547

Merged
merged 2 commits into from
Jun 27, 2024
Merged

clap_complete: Pass a list to __fish_seen_subcommand_from #5547

merged 2 commits into from
Jun 27, 2024

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 25, 2024 •
edited
Loading

This patch:

  • rewrote iterator chains to use explicit loop for easier followup refactorings.
  • prefer passing a list of subcommands to __fish_seen_subcommand_from over passing one-by-one.

@tesuji tesuji force-pushed the fish-list branch 2 times, most recently from baaaaa2 to f61608f Compare June 25, 2024 01:42
@epage
Copy link
Member

epage commented Jun 26, 2024

This patch:

This lists two separate changes. These should be separate commits, if not separate PRs. As for help, I would need more detail on what the problem is.

tesuji
tesuji commented Jun 26, 2024
View reviewed changes
clap_complete/src/shells/fish.rs Outdated Show resolved Hide resolved
clap_complete/tests/snapshots/sub_subcommands.fish Outdated Show resolved Hide resolved
@tesuji tesuji mentioned this pull request Jun 26, 2024
Closed
@tesuji tesuji force-pushed the fish-list branch 3 times, most recently from d69a13b to 2dd10c5 Compare June 27, 2024 00:16
@tesuji tesuji force-pushed the fish-list branch 2 times, most recently from d9e0b60 to 1e3681b Compare June 27, 2024 00:57
@tesuji tesuji changed the title clap_complete/fish: remove unneeded completions clap_complete/fish: Prefer passing a list to __fish_seen_subcommand_from Jun 27, 2024
@tesuji tesuji changed the title clap_complete/fish: Prefer passing a list to __fish_seen_subcommand_from clap_complete: Pass a list to __fish_seen_subcommand_from Jun 27, 2024
@epage epage merged commit 3a2fb25 into clap-rs:master Jun 27, 2024
22 checks passed
@tesuji tesuji deleted the fish-list branch June 27, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesuji @epage