fix(derive): Improve unsupported field type error message #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
value_parser_error
branch
from
1ba6e0d
to
23b20fe
Compare
These are now running in other situations in CI and feature combinations have odd side effects on the output.
This is a bit more unconventional but I think its sufficient improvement to readability to justify it.
epage
force-pushed
the
value_parser_error
branch
2 times, most recently
from
a55a282
to
dc13365
Compare
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change is a bit more unconventional but I think its sufficient improvement
to readability to justify it.