feat: Implementation of From<Cow<'static, str>> for StyledStr
#5799
Conversation
|
In #5785 (comment) I asked for:
Have those been checked for? For example, |
|
@epage I've added it for |
|
|
||
| impl From<Cow<'static, str>> for StyledStr { | ||
| fn from(value: Cow<'static, str>) -> Self { | ||
| StyledStr(value.to_string()) |
There was a problem hiding this comment.
Please use .into_owned()
to_string can work on any display and can make code more sloppy on refactor.
(sorry, I overlooked this last time and apparently a clippy lint didn't catch this case)
There was a problem hiding this comment.
No, Cow<'static, str>::to_string will cause unnecessary clone on owned case, into_owned is indeed what we want.
Without |
Implemented
From<Cow<'static, str>>forStyledStrunder #5785.(I'm not sure where I was supposed to write the tests for it, so guidance in that would be really appreciated. Thanks!)