added detector for s3 5xxErrors #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsclaranet
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
BzSpi
approved these changes
Jun 8, 2023
| comparator: ">" | ||
| lasting_duration: 5m | ||
| lasting_at_least: 0.9 | ||
| append_condition: and when(requests > ${var.minimum_traffic}) |
There was a problem hiding this comment.
I can't see where the minimum_traffic variable is declared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
i just wrote this detector, please review it if possible.
The ci failed in deploy because of a code i didn't made https://github.com/claranet/terraform-signalfx-detectors/actions/runs/5210445974
I am not sure of the correction to push about that (set-output is deprecated). It seems used in .github/workflows/generator.yml
ping me in slack if possible plz :)
best regards,