Fix of detector Azure MySQL memory usage for standard and flexible Azure MySQL #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aogereau
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
aogereau
changed the title
Shr3ps
approved these changes
Jul 5, 2023
JMHAUTBOIS-Claranet
force-pushed
the
fix_azure_mysql_memory
branch
from
b612234
to
13bc328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #478 , Crit and Major definition were inverted for detector Azure MySQL memory usage for modules integration_azure-flexible-mysql and integration_azure-mysql . Crit is unable to trigger
Both definitions have been fixed in their respective 04-memory.yaml config files, and the detectors / variable terraform files have been regenerated