Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include city codes in our City/Region taxonomy #128

Closed
patrickkaleta opened this issue Nov 18, 2019 · 4 comments
Closed

Include city codes in our City/Region taxonomy #128

patrickkaleta opened this issue Nov 18, 2019 · 4 comments
Assignees
Labels
BB: Scenario Management Scenario Management Building Block enhancement New feature or request

Comments

@patrickkaleta
Copy link
Contributor

Our city/region taxonomy so far only stores the Country it belongs to and the EEA city profile name (which btw is missing in 5-10% of our cities -> @humerh or @therter could this cause any troubles for Emikat our our map/table components?).

We noticed some issues with the calculations in Emikat, which are partly caused by mismatches between City labels (explained here by Heinrich). One solution would be to include city codes in Drupal, so that Emikat can then do the matching based on those city codes.

To do:
@humerh & @negroscuro can you agree on a definition for those city codes, which @negroscuro then makes available, so that @therter can update the Cities/Regions in Drupal using his script. I will then take care of passing these city codes along to Emikat everytime it gets triggered by CSIS.

@patrickkaleta patrickkaleta added the enhancement New feature or request label Nov 18, 2019
@patrickkaleta patrickkaleta added this to the D1.4 CLARITY CSIS v2 milestone Nov 18, 2019
@patrickkaleta patrickkaleta self-assigned this Nov 18, 2019
@p-a-s-c-a-l p-a-s-c-a-l added the BB: Scenario Management Scenario Management Building Block label Nov 18, 2019
@negroscuro
Copy link

negroscuro commented Nov 18, 2019

@heinrich, as we discused already for mortality importing in Atos database, indeed you explained to me, how this codes work, so, what about to remove last 2 digits/letters from a city code which corresponds to city outskirts? so I can provide such fixed city codes for CSIS to import. Is this ok?

image

I just implemented it but just to be sure I would like confirmation from your side.

@therter now mortality layer is providing such reduced city code as well as boundary fo every available city.

@patrickkaleta
Copy link
Contributor Author

I already added a City code field to our Cities/Region taxonomy (machine name: field_city_code), so that we can store the codes in Drupal. I will now prepare the CSIS helpers module to be able to work with this new field.

@therter
Copy link
Contributor

therter commented Nov 21, 2019

I have reimported the cities taxonomy with the data from the mortality layer. The field City code is filled, now.

@patrickkaleta
Copy link
Contributor Author

Ok, from now on the city code is being sent to Emikat with each new Study or Study update, so @humerh you can now do your matching based on the city codes instead of the city names.
parameters-in-emikat

FYI: I've also added the city code to our $studyInfo JSON object, just in case that our components should ever need it as well.

Closing this issue, since from Drupal-side everything is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Scenario Management Scenario Management Building Block enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants