Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study in Poland doesn't show any results for local HC and RIA #29

Closed
3 tasks
patrickkaleta opened this issue Nov 6, 2019 · 8 comments
Closed
3 tasks
Assignees
Labels
BB: Catalogue of ER & AO Catalogue of Elements at Risk and Adaptation Options Building Block bug Something isn't working

Comments

@patrickkaleta
Copy link
Contributor

patrickkaleta commented Nov 6, 2019

  • adding new study doesn't generate all the necessary table entries (always?)
  • impact calculation fails in many places, e.g. Lodz, Gdansk and Tirana regions. It works in Vienna, Linz, Barcelona, Athens, Naples...
  • In Lodz region, no temperature and population results were shown on a map.

See my updates in this comment.


Study 25 (emikat ID: 3183) was just calculated and finished roughly after 15 minutes (with no apparent erros), however the layers for HC local effects and for Risk and Impact assessment don't show anything. (here one example of a result layer for RIA).

BatchJobs look all ok, so I don't know where exactly to look for the error. @humerh can you please investigate this further? Maybe just some kind of caching problem and the result layers are actually already there and showing something?

@patrickkaleta patrickkaleta added the bug Something isn't working label Nov 6, 2019
@p-a-s-c-a-l p-a-s-c-a-l added the BB: Catalogue of ER & AO Catalogue of Elements at Risk and Adaptation Options Building Block label Nov 6, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.4 CLARITY CSIS v2 milestone Nov 6, 2019
@DenoBeno
Copy link
Contributor

DenoBeno commented Nov 6, 2019

"Projects for adaptation" table is empty. In other studies, there is one line for it in the table:

image

Could it be that this entry isn't getting made in new studies anymore? I usually experiment with old studies but this one is new.

@DenoBeno
Copy link
Contributor

DenoBeno commented Nov 6, 2019

If I do the calculation in Poland by re-using some old study, most of the views are built correctly but the mortality isn't:
image

@DenoBeno
Copy link
Contributor

DenoBeno commented Nov 7, 2019

More test results:

I tried to perform a study on several places yesterday. Two in Poland and Tirana/Albania. Always starting from existing study because starting a new study apparently doesn't work properly (see earlier message).

  1. Small village near Gdansk
  • everything worked except for calculating the impact.
  1. Lodz area: city centre and a village next to it.
  • calculations apparently worked, but I wasn't able to see anything in CSIS.
  1. Tirana
  • everything worked except for the impact calculation.

So there are at least two things broken that can be easily repeated:

  1. adding new study doesn't generate all the necessary table entries (always?)
  2. impact calculation fails in many places. It did work in Barcelona...

image

The third one is more difficult. Why would the system calculate everything correctly but fail to show it? in Lodz region? I tried it 3 times there before moving to Tirana - 3x failed and Tirana worked immediately.

@humerh
Copy link

humerh commented Nov 13, 2019

One part of the problem:
In the study definition the city is called LODZ.
In the city table for mortality rates the city PL002C1 is called "Łódź"
Similar, but not the same writing.
For comparing we should switch to city codes.

@DenoBeno
Copy link
Contributor

Yes, I can imagine this could cause problems...

@patrickkaleta
Copy link
Contributor Author

One part of the problem:
In the study definition the city is called LODZ.
In the city table for mortality rates the city PL002C1 is called "Łódź"
Similar, but not the same writing.
For comparing we should switch to city codes.

We are currently not storing city codes in Drupal, but I don't think it should be much of a problem to add them to our City/Region taxonomy. Once we have those city codes, I could update the CSIS helpers module to send the city code as well everytime we trigger Emikat.

@DenoBeno
Copy link
Contributor

Sure. One field more....

@patrickkaleta
Copy link
Contributor Author

patrickkaleta commented Nov 20, 2019

Update:

After looking deeper into those problems together with @humerh we found and solved/are working on solving the following problems:

  • for new Studies no calculations were triggered, because Emikat was expecting the forceRecalculate attribute, which CSIS only sends when updates in existing Studies occur. Heinrich fixed this on Emikat-side and once a new version of Emikat will be deployed that error should disappear
  • for some of the existing studies the calculations showed no result due to a missing entry in one of the tabels (@DenoBeno noticed that in his comment). That was caused by a problem with the versioning, which should be fixed now
  • another reason for no results is a mismatch between the city names, therefore we are currently switching to unique study codes (ongoing in this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Catalogue of ER & AO Catalogue of Elements at Risk and Adaptation Options Building Block bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants