Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SResetPolarity not exported by Prelude #647

Closed
gergoerdi opened this issue Jun 25, 2019 · 2 comments
Closed

SResetPolarity not exported by Prelude #647

gergoerdi opened this issue Jun 25, 2019 · 2 comments

Comments

@gergoerdi
Copy link
Contributor

I have to manually

import Clash.Signal.Internal (SResetPolarity(..))

to be able to define my own KnownDomains. That is probably not intended.

@martijnbastiaan
Copy link
Member

Hmm, I'm not sure. I'd like people to use createDomain, as its much more ergonomic than creating your own instances. See:

https://github.com/clash-lang/clash-compiler/blob/master/clash-prelude/src/Clash/Signal/Internal.hs#L394

The docs at

https://github.com/clash-lang/clash-compiler/blob/master/clash-prelude/src/Clash/Signal.hs#L46-L49

could probably mention this.

@martijnbastiaan
Copy link
Member

Actually, it should be exported as it has a valid usecase in combination with knownDomain - just like the other GADTs are. I'll merge a patch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants