Release 1.6.1 #2091
Release 1.6.1 #2091
Conversation
martijnbastiaan
force-pushed
the
release-1.6.1
branch
3 times, most recently
from
558c034
to
21cd0a0
Compare
martijnbastiaan
force-pushed
the
release-1.6.1
branch
from
cb9e09a
to
859abdf
Compare
|
It occurred to me that checking for the presence of |
We disable `multiple_hidden` on releases. Or rather, we've agreed to do that, but yours truly forgot to when releasing v1.6.0. This check ensures that doesn't happen again.
martijnbastiaan
force-pushed
the
release-1.6.1
branch
from
859abdf
to
7d11a2b
Compare
|
So, how long until |
|
😩 |
|
We should commit the CI checks to |
|
No, because on master we do want multiple-hidden enabled |
| # `tag_version` is set when a tag has been created on GitHub. We use this to | ||
| # trigger a release pipeline (release to Snap / Hackage). |
There was a problem hiding this comment.
Christiaan, unless I'm quite mistaken, this prevents the multiple-hidden check on master. Also, if we don't commit the check to master, we might fall in the same trap for 1.8. So if this code cannot be added to master we should decide how we can add it to master instead of just not doing the check at all.
There was a problem hiding this comment.
That's correct @DigitalBrains1. We should commit it to master too. These commits should be forward ported:
Are we doing release names yet? If so, I'd like to call this one Whoopsie Daisy.
Sorry @gergoerdi, @rowanG077, and thanks for noticing!