Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script for min initial deposit ratio test #185

Merged
merged 2 commits into from
Mar 18, 2023
Merged

add script for min initial deposit ratio test #185

merged 2 commits into from
Mar 18, 2023

Conversation

fragwuerdig
Copy link
Collaborator

@fragwuerdig fragwuerdig commented Mar 17, 2023

This is just the test I used locally to test the min-initial-deposit feature. Run inside root folder of repo - like so:

contrib/localnet/deposit-test.sh

I leave it here more or less for reference. As the good ol' devs say: Works on my machine!

Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wee will need to align the ENV vars at some point in the future, e.g. TESTNET_CHAINID should probably just map to the CHAINID ENV, but this is great work :)

@ZaradarBH ZaradarBH added enhancement New feature or request Value-Add labels Mar 17, 2023
@ZaradarBH ZaradarBH added this to the Core - v2.0.0 milestone Mar 17, 2023
@ZaradarBH ZaradarBH merged commit ff2e40b into main Mar 18, 2023
@fragwuerdig fragwuerdig deleted the deposit-test branch March 18, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants