-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share link #55
Share link #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome functionality. A couple of notes, happy to merge after addressing these or moving to new follow-up issues:
- URL is cleaned after load, but tab title is still full with hacky symbols
- Seems experiments are not run at first
- Eventually would be nice to have full app state in URL
- Consider using a dialog instead so user actively presses copy button rather than automatically filling his clipboard.
Aka when config changes then final height is updated as well.
Unable to replicate in Chrome and Firefox on Windows the tab title is hash free
Fixed in 1b4bb76
Created #61
Dialog implemented, see screenshot pr description. |
Fixes #49
TODO
Example urls