Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share link #55

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Share link #55

merged 11 commits into from
Oct 17, 2024

Conversation

sverhoeven
Copy link
Collaborator

@sverhoeven sverhoeven commented Oct 11, 2024

Fixes #49

TODO

  • add share button to experiment
  • add toaster to give user feedback
  • on mount load experiment from # when present
  • when experiment in hash url is corrupt, give nice error

Example urls

localhost_3000_ (5)

@sverhoeven sverhoeven marked this pull request as ready for review October 11, 2024 11:21
@sverhoeven sverhoeven requested a review from Peter9192 October 11, 2024 11:21
Copy link
Member

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome functionality. A couple of notes, happy to merge after addressing these or moving to new follow-up issues:

  • URL is cleaned after load, but tab title is still full with hacky symbols
  • Seems experiments are not run at first
  • Eventually would be nice to have full app state in URL
  • Consider using a dialog instead so user actively presses copy button rather than automatically filling his clipboard.

@sverhoeven
Copy link
Collaborator Author

Awesome functionality. A couple of notes, happy to merge after addressing these or moving to new follow-up issues:

  • URL is cleaned after load, but tab title is still full with hacky symbols

Unable to replicate in Chrome and Firefox on Windows the tab title is hash free

  • Seems experiments are not run at first

Fixed in 1b4bb76

  • Eventually would be nice to have full app state in URL

Created #61

  • Consider using a dialog instead so user actively presses copy button rather than automatically filling his clipboard.

Dialog implemented, see screenshot pr description.

@sverhoeven sverhoeven merged commit 51284f3 into main Oct 17, 2024
4 checks passed
@sverhoeven sverhoeven deleted the share-link branch October 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration via URLparams
2 participants