-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make session share button + persist to local storage #72
Conversation
Moves ShareButton from experiment to whole app TODO - [ ] Handle inline todos
Uploading big experiment twice causes very slow setExperiments calls
Fixing by storing outputs outside store. |
class-web/apps/class-solid/src/lib/store.ts Lines 90 to 93 in c9eaead
|
Fixes #63 or when a experiment is present the + button will show in dialog. |
Rollback outputs premature optimization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed interactively
Partially reverts 0dff547
Hmm, with outputs back in store, adding the permutation sweep, the ui is slower. Duplicating experiment is even slower. |
Refs #61
Fixes #20
Moves ShareButton from experiment to whole app
TODO